cosmpy icon indicating copy to clipboard operation
cosmpy copied to clipboard

Add support for URLs with paths

Open dylanschultzie opened this issue 1 year ago • 1 comments

Proposed Changes

Adds support for REST urls with paths. Currently the assumption is a url will end with the port and/or dns, for example, rest+https://cosmoshub-api.lavenderfive.com:443. This PR adds support for the following: rest+https://rpc.cosmos.directory:443/cosmoshub.

Linked Issues

NA

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • [ ] Bug fix (non-breaking change that fixes an issue).
  • [x] New feature added (non-breaking change that adds functionality).
  • [ ] Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • [ ] Documentation update.
  • [ ] Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • [x] I have read the CONTRIBUTING guide
  • [x] Checks and tests pass locally

If applicable

  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] I have checked that code coverage does not decrease
  • [ ] I have added/updated the documentation

Further comments

[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]

dylanschultzie avatar Nov 27 '24 21:11 dylanschultzie

Thank you for your contribution. @pbukva Can you please take a look at this?

kshipra-fetch avatar Dec 06 '24 09:12 kshipra-fetch