FESTIM icon indicating copy to clipboard operation
FESTIM copied to clipboard

Total Volume for Cylindrical and Spherical meshes

Open rekomodo opened this issue 1 year ago • 1 comments

Proposed changes

Implements TotalVolume derived quantities for both Cylindrical and Spherical meshes as per #723 .

Types of changes

What types of changes does your code introduce to FESTIM?

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Code refactoring
  • [ ] Documentation Update (if none of the other choices apply)
  • [x] New tests

Checklist

  • [x] Black formatted
  • [x] Unit tests pass locally with my changes
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

rekomodo avatar Sep 01 '24 18:09 rekomodo

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.49%. Comparing base (abe3942) to head (9dfb219). Report is 138 commits behind head on main.

Files with missing lines Patch % Lines
festim/exports/derived_quantities/total_volume.py 95.91% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   99.56%   99.49%   -0.07%     
==========================================
  Files          61       61              
  Lines        2750     2799      +49     
==========================================
+ Hits         2738     2785      +47     
- Misses         12       14       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 01 '24 18:09 codecov[bot]

Closing as replaced by #939

RemDelaporteMathurin avatar Jan 21 '25 15:01 RemDelaporteMathurin