Rob Reynolds issues

Results 158 issues of


                                            Rob Reynolds

Guideline: Check for copying to program files and flag

Nothing should have a need to copy to program files without a really good reason. The native installer should make the changes required. However if someone is just deciding that...

Guideline: Flag the use of hardcoded uninstall paths

Note: Flag the download urls if the domain doesn't match the projecturl and not github, fosshub or other well-known location

Note: Duplicate Package

Check for duplicate packages. Provide it as a note. This will be done after the initial onslaught of the backlog is completed.

NOTE: Ensure remove-item / remove* are wrapped with guards

Detect and leave a note for moderators to review that these are wrapped with guards to ensure that the value if a variable is null or not prior to running...

Note: If packageSourceUrl matches the projectUrl and it is not github, bitbucket or codeplex, flag it

Guideline: Use of http instead of https

[Required] No temporary/backup files should be in the package

https://chocolatey.org/packages/classified-ads/0.11#files Note the ~ file.

Requirement: Use Get-BinRoot or Get-ToolsLocation, never the environment variables directly

This will ensure folks do the right thing when packaging.

Requirement: no requires powershell -version 2 in automation scripts

It looks like a good idea to ensure compatibility, but it breaks on newer versions of Windows that don't have the PowerShell v2 engine feature turned on by default.