bitvec icon indicating copy to clipboard operation
bitvec copied to clipboard

Remove extra umlauts on `a` and `e` in english words

Open thement opened this issue 3 years ago • 1 comments

thement avatar Nov 09 '22 20:11 thement

Oh hey, I just saw this PR. This extra umlauts issue also caught my eye in my PR, where I asked what the intention of the extra umlauts is, or weather they should be removed or not.

I'm happy to see you already did this change, however I notice it is incomplete: there are also extra umlauts on i, o and u – that is there are ï, ö and ü characters.

Given there was no reaction to your PR at all so far, I would understand your reluctance to fix that as well. I wonder if pinging the author on another channel would help? Though I'd think PRs would be high on the list of things to automatically look at, and it's just life getting in the way or something.

Edit: "life getting in the way" seems to be the case, according to this README. Given that was 7 months ago I'll send an email to ask.

shrugalic avatar Dec 31 '22 07:12 shrugalic