simple-websocket icon indicating copy to clipboard operation
simple-websocket copied to clipboard

Feature request: unref() method

Open DiegoRBaquero opened this issue 8 years ago • 2 comments

It would be cool if unref() was implemented:

https://nodejs.org/api/net.html#net_socket_unref

DiegoRBaquero avatar Mar 04 '17 04:03 DiegoRBaquero

Sure, interested in sending a PR?

I saw your issue https://github.com/websockets/ws/issues/1031 so I think the main thing to watch out for is if the user calls socket.unref() before the underlying socket is ready. That would need to be queued until the socket becomes ready.

feross avatar Mar 07 '17 21:03 feross

Sure, will do when I find some time!

DiegoRBaquero avatar Mar 07 '17 21:03 DiegoRBaquero