simple-peer icon indicating copy to clipboard operation
simple-peer copied to clipboard

When Simple-peer ICECOMPLETE_TIMEOUT is set to 1000 milliseconds Webtorrent performs MUCH faster

Open zackees opened this issue 1 year ago • 0 comments

What version of this package are you using?

Webtorrent v1.8.26

What operating system, Node.js, and npm version?

Win10 with brave:

Version 1.41.100 Chromium: 103.0.5060.134 (Official Build) (64-bit)

What happened?

Client never connects faster than 5.5 seconds, until ICECOMPLETE_TIMEOUT is set to a different value like 1000, in which case client will connect within 1.5 seconds.

What did you expect to happen?

I would expect the client to connect as fast as possible.

Are you willing to submit a pull request to fix this bug?

Maybe. I'm pointing this bug out so that others hitting this issue can find this bug report.

Reference points:

https://github.com/feross/simple-peer/blob/f1a492d1999ce727fa87193ebdea20ac89c1fc6d/index.js#L11

https://github.com/feross/simple-peer/blob/f1a492d1999ce727fa87193ebdea20ac89c1fc6d/index.js#L596

zackees avatar Jul 31 '22 22:07 zackees