simple-peer icon indicating copy to clipboard operation
simple-peer copied to clipboard

fix: return `this` from `destroy()`

Open danielroe opened this issue 2 years ago • 2 comments

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [x] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview)

This simply returns this from destroy() - quite a minor change but which brings the implemenation of Duplex into line with current Node implementation.

Which issue (if any) does this pull request address?

For consistency with Node readable stream implementation, destroy() should return this - https://nodejs.org/api/stream.html#readabledestroyerror

Is there anything you'd like reviewers to focus on?

Context: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/57473

danielroe avatar Dec 01 '21 22:12 danielroe

News about this PR?

rprata avatar Apr 22 '22 02:04 rprata

@feross pls you can review this PR ?

ViniciusFXavier avatar Nov 16 '22 04:11 ViniciusFXavier