simple-peer icon indicating copy to clipboard operation
simple-peer copied to clipboard

(Attempt to) Implement ICE Restarts

Open soup-in-boots opened this issue 3 years ago • 7 comments

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [X] New feature [ ] Other, please explain:

What changes did you make? (Give an overview) Added an iceRestartEnabled option; when set to a truthy value, will prevent transitions from to the "failed" state from destroying the peer. Further, if enabled and the failed state is reached, will automatically initiate an ICE restart.

Added a restart function which, when called by the initiator, will invoke restartIce on the underlying RTCPeerConnection.

Which issue (if any) does this pull request address? #579

Is there anything you'd like reviewers to focus on? Advice for test cases. Additionally, I don't know the broader implications of these changes, so I'll be relying on you all to guide me in that respect.

soup-in-boots avatar Dec 14 '20 09:12 soup-in-boots

For the record, the build is failing in 14.x due to a bug in wrtc: https://github.com/node-webrtc/node-webrtc/issues/636

soup-in-boots avatar Dec 15 '20 00:12 soup-in-boots

Hi! I'm interested in using this functionality in simple-peer. Would it help if I use the changes @fauxsoup made and create an MR that is mergable?

DJFliX avatar Jun 21 '21 15:06 DJFliX

I have resolved the merge conflict. Can I get some feedback on this? I would love to get this up to your standards and merged!

soup-in-boots avatar Aug 08 '21 16:08 soup-in-boots

cc @feross

lofcz avatar Aug 12 '21 20:08 lofcz

cc @feross

sooryranga avatar Aug 18 '21 03:08 sooryranga

Rebased onto the latest version. Please let me know if there's anything more I can do.

soup-in-boots avatar Oct 27 '21 16:10 soup-in-boots

@fauxsoup I'm waiting for this feature. If there's anything you need help with to make this PR successful, let me know!

michalzaq12 avatar Dec 10 '21 12:12 michalzaq12