simple-peer
simple-peer copied to clipboard
Improve documentation around signalling
Not a bug but a suggestion:
I think it'd be easier for newbies if trickle was set to false by default. While the examples use clients on a same context and multiple candidates are shared automatically, developers will likely use a signaling server. When building out a signaling server, its not immediately obvious you need to handle multiple signals from the same peer. Setting trickle to false by default would hopefully save a lot of headaches.
trickle:false
won't ensure only a single signal message. If you addStream
after negotiation completes, you'll get more messages.
Disabling trickle is kind of terrible - it stalls establishing the connection until ICE fully completes. I don't think poor performance should be the default.
Maybe this is a documentation bug rather than an issue with the defaults?
Thats a fair point. Didn't realize addStream
would require additional signaling.
Hello @aakilfernandes @t-mullen it seems the documentation isn't added yet, what are the signaling needed for addstream?.