simple-get

simple-get copied to clipboard

Do not follow Location headers for POSTs

6

Currently simple-get will send a duplicated POST request if the response has a location header. I think this is not correct because POST requests are not idempotent. Moreover this is...

mcollina

This switches the public API to use the options defined by WHATWG URL instead of Node.js `http.request`. Avoids depending on deprecated `url` and `querystring`. Background discussion in https://github.com/feross/simple-get/pull/55#issuecomment-1030846150 (targeting `gh-actions`...

LinusU

switch to esm

1

closes #68 maybe take the opportunity to switch to promises also in this major change?

jimmywarting

remove require('url') in favor of URL

2

Closes #53 This also updates travis to use node versions 12 and 10 for tests. node 8.x is at EOL [starting December 2019](https://github.com/nodejs/Release#release-schedule).

Flet

TypeScript types

1

It'd be useful if this module had TS types.

fabiospampinato

> The querystring API is considered [Legacy](https://nodejs.org/api/querystring.html#querystring_query_string). While it is still maintained, new code should use the URLSearchParams API instead. https://github.com/feross/simple-get/blob/81eaf56c012dec4f64f223f4c41811e32ea2ce53/index.js#L9 The npm package is deprecated also: https://www.npmjs.com/package/querystring

jimmywarting

time to drop commonjs support?

jimmywarting

HTTP 500 response not returned with Node.js 14 and concat

1

After upgrading to Node.js 14, I do not receive HTTP 500 responses with code of the form: ``` get.concat('http://example.com', function (err, res, data) { } ); ``` This can be...

arachnetech

From http client to undici?

1

Hi, I was wondering if this module should begin to use https://npm.im/undici instead of the regular node `http/s` client.

alessioalex

So I'm sending a JSON object via the POST method and using `.concat`, but the problem is the endpoint is returning 204 No Content and `simple-get` is trying to parse...

alessioalex