Feross Aboukhadijeh

Results 216 issues of Feross Aboukhadijeh

Thoughts on enabling this rule? https://eslint.org/docs/rules/object-shorthand ECMAScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner. Here...

enhancement
accepted

BREAKING CHANGE: Remove `"TemplateLiteral *"` from the `"ignoredNodes"` in the `indent` rule. This allows the `indent` rule to apply to template literal strings. It's the source of the auto-fixing bug...

enhancement
accepted

https://eslint.org/docs/rules/no-promise-executor-return The `new Promise` constructor accepts a single argument, called an *executor*. ```js const myPromise = new Promise(function executor(resolve, reject) { readFile('foo.txt', function(err, result) { if (err) { reject(err); }...

help wanted
blocked
enhancement

https://eslint.org/docs/rules/func-call-spacing When calling a function, developers may insert optional whitespace between the function’s name and the parentheses that invoke it. Option: "never" (default) disallows space between the function name and...

enhancement

Some developers prefer to sort props names alphabetically to be able to find necessary props easier at the later time. https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-sort-props.md This is the config I tested with and the...

enhancement
ecosystem impact

I noticed this handy package from the react team: https://github.com/facebook/create-react-app/blob/master/packages/eslint-config-react-app/index.js#L24 Looks like they have a list of confusing browser globals. We could enable all the rest to be used without...

enhancement

Proposal to make the [`no-mixed-operators`](http://eslint.org/docs/rules/no-mixed-operators) stricter so it includes bitwise operators. This was suggested by @mafintosh in this comment: https://github.com/feross/standard/issues/566#issuecomment-278827089

enhancement
ecosystem impact

Related to https://github.com/feross/standard/issues/628, there are more `indent` options that we should consider adding. Especially now that ESLint's `indent` rule has been completely rewritten to be stricter and better.

enhancement
ecosystem impact

https://eslint.org/docs/rules/semi https://eslint.org/docs/rules/semi-style

enhancement

https://eslint.org/docs/rules/require-atomic-updates This was surprising to me. Apparently the following code contains a race condition: ```js let totalLength = 0; async function addLengthOfSinglePage(pageNum) { totalLength += await getPageLength(pageNum); } Promise.all([addLengthOfSinglePage(1), addLengthOfSinglePage(2)]).then(()...

blocked
enhancement