ieee754 icon indicating copy to clipboard operation
ieee754 copied to clipboard

Published 20 hours ago • verified publisher icon feross

Handling NaN in consistent with Nodejs

Open geastwood opened this issue 5 years ago • 5 comments

This bug eventually leads to this PR.

geastwood avatar Aug 28 '19 20:08 geastwood

@feross would you take a look?

geastwood avatar Sep 01 '19 07:09 geastwood

@geastwood I haven't looked at this code in a long time. If you wouldn't mind, can you use comments to annotate why each line was changed? I super appreciate it!

feross avatar Sep 04 '19 22:09 feross

Just to bring it in line with nodejs on how to handle NaN and adding a test case for it.

geastwood avatar Sep 09 '19 08:09 geastwood

@geastwood Thanks, but I meant line by line. Like, what was wrong with each line, why did you change it?

feross avatar Sep 10 '19 02:09 feross

@geastwood why was this implementation wrong, not Node's?

dcousens avatar Sep 10 '19 03:09 dcousens