buffer icon indicating copy to clipboard operation
buffer copied to clipboard

Published 20 hours ago • verified publisher icon feross

Tests are out of sync with Node.js tests

Open vmx opened this issue 7 years ago • 10 comments

When running ./bin/download-node-tests.js it's apparent that the tests are heavily out of sync with the Node tests.

I plan to go over them an resync things. I open this issue to prevent double work, so a "go for it" from the maintainers would be appreciated.

vmx avatar Jan 09 '18 14:01 vmx

I'm not a maintainer, but I'll say "go for it" anyway :grinning:

ralphtheninja avatar Jan 09 '18 14:01 ralphtheninja

Merged @vmx's PR and the tests are closer to node's now, but there's still a lot of differences.

feross avatar Feb 16 '18 05:02 feross

I just spent like 3 hours merging in more changes from Node.js, but there's still more changes to be done... wow. Would appreciate help from other folks, if there's interest. @vmx, any interest?

I've started adding the new test files that were added. Once they're all added in, then we can delete test/node/test-buffer.js which has been removed from the original repo. But I don't want to remove it before the other files are merged in, otherwise we'll lose coverage in the meantime.

EDIT: Here's the changes I've made (committed to master already): https://github.com/feross/buffer/compare/e0adc7a07e46d11c70d959c5caa4948d262d1b94...f5aae1035d8e3e78c2264ad9ec9fb13bbc51f08f

feross avatar Feb 16 '18 09:02 feross

Thanks for the review @feross. I still have interest and would spend some time next week. I'll start from the top (alphabetically) and work on the differences. I'll push again in small increments to prevent double efforts.

vmx avatar Feb 16 '18 10:02 vmx

Great, looking forward to a PR next week, @vmx!

feross avatar Feb 16 '18 10:02 feross

Note to self: When all these tests and code changes are merged in, publish a new major version.

feross avatar Feb 16 '18 10:02 feross

Hey all. It's been some time since this issue was opened and buffer was updated. Has the herd moved to another implementation/fork? Or is there still a roadmap for this one to be actively developed? Just curious.

superguineapig avatar Nov 27 '18 00:11 superguineapig

@superguineapig When I was talking with @feross he said he's happy to see those fixes. So my currnet workflow is doing some of those fixes, waiting for a review (wow, it's been a long time for #190 being open) and merge and then doing some more whenever I find time.

vmx avatar Nov 27 '18 00:11 vmx

Thanks for the info @vmx Glad to hear the project is still alive.

superguineapig avatar Nov 27 '18 18:11 superguineapig

I'm in grad school as of the past year, so I was off GitHub for a while. Still around and still plan to maintain this as good as ever. :)

feross avatar Sep 05 '19 20:09 feross