office-ribbonx-editor icon indicating copy to clipboard operation
office-ribbonx-editor copied to clipboard

Settings don't apply to tabs opened since the dialog was opened

Open fernandreu opened this issue 3 years ago • 0 comments

Describe the bug If a tab was opened since the settings dialog was opened, any change in editor settings won't apply to it.

To Reproduce Steps to reproduce the behavior:

  1. Open settings
  2. While the settings dialog is still shown, open an editor tab
  3. Make changes to the editor settings: colors, font size, etc.
  4. Click on Apply / Accept
  5. The opened editor tab will look exactly as before

Expected behavior The changes in editor settings should be applied to any open editor tab, no matter when they were opened.

Additional context The changes apply if the editor tab is reopened or if the tool is restarted, so it is only a temporary issue. This occurs because the settings dialog holds a reference to all tabs opened but the latter isn't refreshed when it should.

fernandreu avatar Nov 29 '21 13:11 fernandreu