Fernando Serrano
Fernando Serrano
I agree with @dmarcos, I feel that these events belong to the controllers and not to the mapping, in the mapping we could take these and convert to actions but...
A WIP PR that should fix this issue: https://github.com/fernandojsg/aframe-input-mapping-component/pull/19
I admit I was thinking initially about going for 3 but then I thought I could be a bit overengineering using callback for each button. As you comment it will...
When developing it I agreed with @dmarcos that grouping by controller is more easy to understand when you are creating the mapping. But I was thinking also about adding new...
In that case maybe adding a new item to clarify the different reserved keywords? ``` AFRAME.registerInputMappings({ actions: { mute: { label: 'Shhhh' }, teleport: { label: 'Go there' } ......
Cool, so we agree on the `actions` and `states` grouping. Regarding the `details` even though I find it interesting and probably useful, I would leave it out of the first...
Thinking again about the use of `actions`, if we want to use it to set labels for each action, we could eventually want to set the tooltips positions for each...
We could even use these `controllers` section we could use it eventually for many things to reduce the logic on the app: change the colors depending on the state, change...
@ngokevin I don't get this change, isn't that what we already do on https://github.com/fernandojsg/aframe-slice9-component/blob/master/index.js#L174-L177 In any case is not a good idea to create new geometry on width/height change, imagine...
@dbradleyfl Hi! sorry for the delay. I was checking an old branch I had trying to migrate to WebXR and I found some other issues and bugs that the original...