serverless-finch icon indicating copy to clipboard operation
serverless-finch copied to clipboard

Add option for excluding files to deploy

Open joshpassenger opened this issue 6 years ago • 4 comments

This is a:

  • [X] Feature request or change

Current behaviour

Finch deploys all files by default, including .DS_Store files

Proposed behavioir

Add option to exclude files to deploy by glob pattern

Justification

Lots of temporary files exist .gitignore, .DS_Store etc please consider an options for excluding these

joshpassenger avatar Nov 02 '18 01:11 joshpassenger

@joshpassenger sounds like a decent feature. You're welcome to open a PR that supports this and I'll review/accept. One thing I am curious about is why this shouldn't be handled by the build process itself? I imagine the .gitignore at the root of the repo which means you would be deploying a submodule in this case then?

Either way, seems like this makes sense as a general feature, thanks for the suggestion! Let me know if you're interested in implementing it, otherwise it may sit here for a while until I can find someone who has a spare moment.

fernando-mc avatar Nov 02 '18 04:11 fernando-mc

Hi @fernando-mc I'll have a look at the complexity of implementing it!

It was more for dev deployments from my local machine, I have a .gitignore which would prevent these files from making it to a CICD server via git checkout.

joshpassenger avatar Nov 02 '18 06:11 joshpassenger

Assign it to me?

joshpassenger avatar Nov 02 '18 06:11 joshpassenger

@joshpassenger done! Thanks for the reminder 😁

fernando-mc avatar Nov 04 '18 03:11 fernando-mc