fern icon indicating copy to clipboard operation
fern copied to clipboard

(fix): updating sdk invocation versions

Open bsinghvi opened this issue 10 months ago • 6 comments

Used the generator versions here - https://github.com/fern-api/fern?tab=readme-ov-file + the changelog to decide on the default version.

bsinghvi avatar Apr 17 '24 23:04 bsinghvi

@bsinghvi you'll need to fix ete tests here yarn workspace @fern-api/ete-tests test -u and then we are g2g

dsinghvi avatar Apr 18 '24 00:04 dsinghvi

is there a way to make this dynamic? I'm inspired by what Armando did here: https://github.com/fern-api/fern/blob/8633c289e09088ad865303c8b74005dea260dda9/README.md?plain=1#L79)

dannysheridan avatar Apr 18 '24 00:04 dannysheridan

@dannysheridan there would still have to be some level of manual intervention to determine which version we should mark as safe to be the default invocation version. right now, Armando's just grabs the latest, which could potentially not be release safe

bsinghvi avatar Apr 18 '24 01:04 bsinghvi

is there a way to make this dynamic? I'm inspired by what Armando did here:

https://github.com/fern-api/fern/blob/8633c289e09088ad865303c8b74005dea260dda9/README.md?plain=1#L79

)

@dannysheridan there would still have to be some level of manual intervention to determine which version we should mark as safe to be the default invocation version. right now, Armando's just grabs the latest, which could potentially not be release safe

That's right -- in fact the latest TS release has some issues so have to wait to merge this

dsinghvi avatar Apr 18 '24 10:04 dsinghvi

@dsinghvi this PR doesn't update it to the latest for the TypeScript SDK - are there concerns with 12.9?

bsinghvi avatar Apr 18 '24 14:04 bsinghvi

image getting an error when I try to run: yarn workspace @fern-api/ete-tests test -u

@dsinghvi can you land this PR?

dannysheridan avatar May 27 '24 20:05 dannysheridan