spin icon indicating copy to clipboard operation
spin copied to clipboard

Bindle manifests still use camelCased keys

Open lann opened this issue 1 year ago • 2 comments

Looks like this was missed back in https://github.com/fermyon/spin/pull/157 and hasn't been a problem until recent testing.

lann avatar Oct 04 '22 20:10 lann

This looks promising: https://crates.io/crates/serde_alias

lann avatar Oct 04 '22 21:10 lann

It turns out the only field that really matters here is allowed_http_hosts / allowedHttpHosts.

Fixing this will require updating hippo, which does expect allowedHttpHosts:

https://github.com/deislabs/hippo/blob/c9c09e9df6b38787e7817754ce6660bad566dc57/src/Infrastructure/Services/BindleService.cs#L63

https://github.com/deislabs/hippo/blob/627b51e1ef368349c964353e7dab591157ce9278/src/Application/Common/Interfaces/BindleService/RevisionComponent.cs#L23

lann avatar Oct 05 '22 15:10 lann