spin icon indicating copy to clipboard operation
spin copied to clipboard

Request ID

Open itowlson opened this issue 1 year ago • 4 comments

This is a possible approach to #2146 but I feel kinda queasy using an environment variable instead of an API but maybe that's just me

itowlson avatar Apr 02 '24 03:04 itowlson

I am curious if this would be needed once we have wasi-observe and otel?

karthik2804 avatar Apr 02 '24 05:04 karthik2804

@karthik2804 on that I was guided by https://github.com/fermyon/spin/issues/2146#issuecomment-2000217985 but for sure I do not know enough either way

itowlson avatar Apr 03 '24 22:04 itowlson

Could this (also?) be a Spin variable?

radu-matei avatar Apr 15 '24 13:04 radu-matei

I think this may in fact be best served via wasi-observe. Distributed traces are typically keyed off of a trace ID which is either passed in via e.g. W3C Trace Context or generated by the server (if it is the first hop in the traced system). That trace ID could be emitted with logs and - if necessary - exposed to the guest via a wasi-observe import.

lann avatar Apr 15 '24 13:04 lann