spin icon indicating copy to clipboard operation
spin copied to clipboard

Improved rumqttc event loop check.

Open suneetnangia opened this issue 1 year ago • 8 comments

suneetnangia avatar Mar 13 '24 22:03 suneetnangia

The CI failure in the plugins test is because an external web server is returning a different error from the one we expected; it has nothing to do with this PR and can be overridden (assuming there are no other failures)

itowlson avatar Mar 13 '24 23:03 itowlson

@suneetnangia Is this intentionally still draft? No rush, just checking that it's deliberate.

itowlson avatar Mar 13 '24 23:03 itowlson

@suneetnangia Is this intentionally still draft? No rush, just checking that it's deliberate. We can merge now, I was trying to see if there's any better way, will raise subsequent PR as needed but for now it brings stability to the publish part.

suneetnangia avatar Mar 14 '24 08:03 suneetnangia

@itowlson do we have a performance testing project for these outbound and triggers components? Ideally, I want to hammer MQTT trigger and publish component at some point. For now, I have improved the code but I definitely think it can be better e.g. running eventloop async task as soon as connection is created, I'll spend sometime on it later. Thanks

suneetnangia avatar Mar 14 '24 12:03 suneetnangia

~@vdice Can you force merge this please? The CI error is unrelated to the PR.~

itowlson avatar Mar 14 '24 18:03 itowlson

Since our last comment here, I've tested a better solution (as I alluded to) with a few thousand messages (100k or so). Updated.

suneetnangia avatar Mar 14 '24 18:03 suneetnangia

@vdice sorry, please hold off, still some changes happening after all

itowlson avatar Mar 14 '24 19:03 itowlson

@suneetnangia Not to rush you, but do we have a way forward here? Failing that, is there an intermediate solution that's "better than today" even if not perfect? Thanks!

itowlson avatar Mar 21 '24 20:03 itowlson

@suneetnangia Not to rush you, but do we have a way forward here? Failing that, is there an intermediate solution that's "better than today" even if not perfect? Thanks!

@itowlson this PR now have the fix (rolled back latest one) which makes it much better than it's current state (in fact current does not work), if we can get this in for now and I'll look at better solution next week... have some time off.

suneetnangia avatar Mar 28 '24 17:03 suneetnangia

Thank you @suneetnangia and enjoy your break!

itowlson avatar Apr 01 '24 19:04 itowlson