Ferenc Erki

Results 143 comments of Ferenc Erki
trafficstars

So, behind the scenes Rex::CLI does a few hoops to [load the Rexfile](https://github.com/RexOps/Rex/blob/805133f2d9ea03c9b6e72d8815d99bc00bd25381/lib/Rex/CLI.pm#L682-L791) properly, do some sanity check, and make the Rexfile available in the same way as if it...

> > Currently I'm leaning towards banning get cmdb (and probably other) calls outside tasks by printing a warning and documenting the intended usage more closely, because now it gets...

My current idea is to use [`capture_stderr`](https://metacpan.org/pod/Capture::Tiny#capture_stderr) or [`tee_stderr`](https://metacpan.org/pod/Capture::Tiny#tee_stderr) from Capture::Tiny instead of the current local "hijacking" in Rex::CLI. I'm pretty sure that module will come in handy elsewhere in...

FTR, I'm just attaching my initial notes on the review of the potentially affected range of commits. [merge_backport_review.txt](https://github.com/RexOps/Rex/files/4678580/merge_backport_review.txt) Legend for markers on the first character of the line: - `x`:...

Thanks for this PR, @tabulon! I'm going to comment on your points first below before doing a full review. --- > While this is clearly bug fix, it can't be...

Alright, the perlcritic tests should be solved by now via #1516. Please [rebase](https://www.w3docs.com/snippets/git/how-to-rebase-git-branch.html) these changes on top of the default branch in order to test them against the current state....

> Meanwhile, please note that t/needs.t also has multiple packages in it (all except the helper package T). Yup, as explained above that's considered as our "accepted legacy". It either...

Thank you for the detailed bug report, @rwp0! :heart: Your analysis is correct: `desc` can also provide a description for batches and environments, not just tasks. These cases are indeed...

Thanks for your contribution, @giterlizzi, and for you patience! This PR does not fully follow the project's expectations, so I'd like to take this chance to kindly link our [Contributing...

Thank for the report, @djzort! In the case of `account ..., crypt_password => $encrypted_password`, Rex translates that to a `usermod -p '$encrypted_password'` call (on Linux endpoints), which in turn will...