Ferenc Erki

Results 161 comments of Ferenc Erki

> Windows tests are failing (chmod error) My first thought was that Windows doesn't have `chmod`, but apparently Rex:Interface::Base::chmod() [should fake success]((https://github.com/RexOps/Rex/blob/9899caafcf8fb847f2cefe586ea7b80d9ff70cb0/lib/Rex/Interface/Fs/Base.pm#L154)) in those cases (and `t/file.t` should also [cover...

@kablamo: it might be because it's early morning for me, but I can't see it yet how that would add real value on top of the existing methods/notations. What advantages...

@krimdomu: yeah, I know and agree that it's likely to be accepted (whoops, I forgot that part in my first comment), I was just genuinely interested in the reasons (partly...

@kablamo: no worries, it's not being considered as noise at all ;) The space separated notation for `-H` is on the landing page on rexify.org, though we don't seem to...

Thanks for the suggestion, @mrmuskrat :+1: The matters related to the website belong to the RexOps/rexify-website repo, so I created a new issue there from your comment using GitHub's "Reference...

> There are two issues with sync_up and sync_down Then I would recommend opening two separate GitHub issues ;) I'm OK treating Nr. 1 as a bug, but Nr 2....

> It seems to me that sync_down's excludes should work the same as sync_up and allow excluding directories. @mrmuskrat: yes, I agree in principle :+1: I didn't look into deeper...

> @ferki I can chop off fixing how excludes work from the PR, but then I will not deliver as detailed tests for sync_up/down with excludes. I just don't get...

Thanks again for this PR, and your patience, @gregoa! I expected it would be a straightforward merge, but the more I look at it, the more legal/licensing questions keep bothering...

@bollwarm: you're right, but having a _group_ error in this case still sounds a bit weird ^^