ferinagy

Results 15 comments of ferinagy

Just to add, also support kotlin extensions would be great. For now, it seems to work to do `view.applySystemWindowInsetsToMargin(left = true, right = true)`, but feels a bit weird.

Hi, I took a look and it seems to be fixed with converting `ComponentFilter` to a fun interface: ```kotlin @HasImplicitReceiver fun interface ComponentFilter { fun reject(candidate: ComponentSelectionWithCurrent): Boolean } ```...

Just for inspiration, in our project I use: ``` resolutionStrategy { componentSelection { all { fun String.stability(): Int = when { this.contains("alpha") -> 0 this.contains("beta") -> 1 this.contains("rc") -> 2...

That is unfortunate, I did not notice it still has `@ExperimentalCoroutinesApi`. Is there anyway we could do this locally - like via some `CallAdapter`? Or do we need to fork...

Hi, I hit this a few times recently, so I thought I'd give it a shot: https://github.com/square/retrofit/pull/3544. Any feedback is welcome.

> Why not use kotlinx-metadata? It's in the name of the issue https://github.com/square/retrofit/issues/3075: `"...and avoid kotlin-metadata-jvm dep"`. 🤷 That is actually how I started, I can fairly easily put it...

Hi, no pressure here, but if I can explain or clean up the code to help with reviewing this, let me know.

I did another pass through this. I cleaned up some stuff, marked which parts were extracted from `kotlinx-metadata-jvm` and `kotlinx.serialization`, and added some comments to the rest. Any feedback will...

I ran into similar issue. My minimal repro case is: ```kotlin import io.mockk.every import io.mockk.mockk import org.junit.Test class MockkTest { @Test fun test() { mockk { every { state }...

I just run into this issue when our tests would fail on emulator, but run on physical device. I used `git bisect` and identified the commit that caused the issue...