ferhat elmas comments

Results 38 comments of


                                            ferhat elmas

Gem is misnamed causing additional work during implementation

@krschacht Thanks. I am not a part of the team anymore but I am sure that team will take a swift action.

Suggestion to add golangci-lint to this project

What is the list of the linters we want to enable? Happy to give a try to enable them

Suggestion to add golangci-lint to this project

Thanks for creating tickets. I will take care of them

Development policy: how are new dependencies added, existing updated or old ones removed?

I thought I could take a stab for this and dropped github.com/hashicorp/go-multierror in #12234 as a starter.

golangci-lint: Enable linters

@pjbgf you can assign it to me.

golangci-lint: Enable linters

I would suggest `gocritic` as well. https://github.com/go-critic/go-critic

Failing tests when running locally due to issue comparing commit who include time.Time

Ideally we should push for upstream to fix IMO. > I can initialize the tests with the current timezone the tests are currently being run with If we prefer no...

Setup golangci-lint for static analysis of backend

Sure, feel free to assign it to me