Frank Dana

Results 954 comments of Frank Dana

Aargh, Well, that failure's for a completely different reason: I forgot you can't do this in Python 3.8: ```python with ( open(some_file) as in1, open(some_file) as in2 ): ``` (It...

Oh! Turns out, the `b53.dot` failure was due to the missing `.` quoting from #419, since I started this branch before that was merged. As soon as I rebased this...

Oh, right, but I still can't do this in Python < 3.10. ```python with ( open(some_file) as in1, open(some_file) as in2 ): ```

This is my least favorite ruff change of all time: ```diff ruff-check: commands[0]> ruff format --diff . --- src/pydot/core.py +++ src/pydot/core.py @@ -264,7 +264,7 @@ def make_quoted(s: str) -> str:...

I just added a number of commits that I was working on as a separate PR, but realized they only make sense in the context of this one, since it...

I also eliminated all of the "punctuation" variables in the parser (things like `comma = Literal(",")` and so on); it's clearer to just use the actual character wherever you mean...

Note to self: Make double-sure that the parsing logic doesn't _unquote_ the node names in this graph: ```dot graph G { "graph" [color=red]; "edge" -- "graph"; } ``` That would...

Glad I thought to check that. It gets it right for edges, but screws up nodes. So, to draft status it goes.

I think this might be done. Even if there's more I _could_ do, it's big enough already that I'd rather save anything further for a separate PR. Oh, I need...

I think this branch is now good, but I'm not sure how reviewable it is anymore. I may have to re-build it on top of the current `main` branch `HEAD`,...