Frank Dana

> * `QImage::bits()` and `QImage::scanline()` provide a non-const pointer to the image data. If the QImage is shared (because of a shallow copy), this causes an automatic duplication of the...

**PREFACE:** (Just _wait_ 'til you see how long this is! I outdid myself, in wasting everyone's time with my bloviating. ...I apologize in advance to anyone foolish enough to continue,...

I built `ffmpeg-3.4.7` on my system in `ilibopenshot/thirdparty` with the following configure line: ```sh ./configure --prefix=/ --disable-libvmaf --enable-cuvid --disable-libfdk-aac --enable-nonfree --enable-libfreetype --enable-libdrm --enable-gnutls --enable-gcrypt --enable-fontconfig --enable-libmp3lame --enable-libgsm --enable-libopenjpeg --enable-librsvg --enable-libssh...

Here's the output of a `backtrace` in `gdb`, after running `openshot-test` through to the crash: ``` (gdb) bt #0 0x00007ffff3ef0625 in raise () at /lib64/libc.so.6 #1 0x00007ffff3ed98d9 in abort ()...

Actually, more informative might be this, from the output of the `run` instruction in `gdb`: ``` [Thread 0x7fffe77fe700 (LWP 3369901) exited] [Thread 0x7fffe7fff700 (LWP 3369902) exited] [Thread 0x7fffe6ffd700 (LWP 3369900)...

Fair point, though a failing PR can't be merged anyway. Still... done.

It's coming along nicely, though! As a sort of coarse metric, here are the results of `valgrind` runs on this code vs. the `develop` branch, both built against my system...

(I can say that the remaining "definitely lost" in `tests/openshot-test` are **mostly** in FFmpegReader, plus a few in ZmqLogger... though `FFmpegWriter::write_audio_packets()` and `FFmpegWriter::auto_detect_format()` do seem to still be leaking a...

BTW, not to contradict your latest commit message, but it seems `Close()` **doesn't** call `free_resources()`, currently. (And in fact, since the only thing the destructor does is call `free_resources()`, as...

OK, attached are the complete output of the following two commands, run in my worktree for this PR and built against FFmpeg 4.2.2: ```sh valgrind -s --track-origins=yes --leak-check=full --show-leak-kinds=all tests/openshot-test...