hugo-bin icon indicating copy to clipboard operation
hugo-bin copied to clipboard

feat: Allowing to overwrite the Download Repository aka Download Mirror

Open jweberde opened this issue 3 years ago • 3 comments

When using hugo-bin within corporate environments it is often required to use a corporate proxy repository like Artifactory to download your dependencies, because access to internet is restricted.

I extended your implementation for switching to the extended version and now it is allowing to set a downloadRepo parameter which will replace the default https://github.com

fixes #112

jweberde avatar Apr 11 '22 09:04 jweberde

LGTM now, one last thing: maybe it'd be better if we used uvu's hooks to set/reset npm_config_hugo_bin_build_tag and npm_config_hugo_bin_download_repo? https://github.com/lukeed/uvu/blob/master/docs/api.uvu.md#hooks?

XhmikosR avatar Apr 21 '22 18:04 XhmikosR

I was also not happy with the node env isolation for the test case, but actually did not spent too much time on it. Good Idea with the test suite. I split the test cases in an own suite and ensured that the env variables are really cleaned before each test run.

I do not know if we should split the test case in 2 Files, but until now I guess thats kind of an overkill.

jweberde avatar Apr 22 '22 07:04 jweberde

Could move forward with the pull request?

jweberde avatar May 03 '22 09:05 jweberde