Han comments

Results 5 comments of

Han

`test` / `it`, and `describe` should follow the same pattern as `@playwright/test` for test context extensions

> This is a nice feature. If anyone is willing to implement it, PR is welcome :) This is cool! I would like to give it a try.

feat(config): deprecate `cache.dir` option

> Deprecating is not a breaking change as long as it's still resolved. Aha...thanks for clarifying! As you said it's still resolved, do I need to handle `cache.dir` in resolving...

fix(vitest): logs in `beforeAll` and `afterAll`

> @fenghan34 hey! can you fix merge conflicts when you have time, please? 🙏🏻 Sure I will do it soon

`toEqual/toStrictEqual` does not check custom Error properties

This happened as both `DataTaggedError` and `SchemaTaggedError` are extended from `Error`, and for Error objects, now Vitest will only checks the `message` prop. https://github.com/vitest-dev/vitest/blob/c692f76e58ae11fcc13631adcb4b80055843d447/packages/expect/src/jest-utils.ts#L98 Perhaps Vitest need to do more...

`toEqual/toStrictEqual` does not check custom Error properties

> even they are extending from Error, I would expect from the `toStrictEqual` to check if all key values matches. Does that make sense? @steffanek Yes, It makes sense to...