François Laignel

Results 34 comments of François Laignel

Almost forgot: there's something else I need to address. In existing GStreamer Vorbis decoders, there is a mapping between the codec's channel positions and the framework's conventions. I think we...

> unfortunately I'm a bit short on time at the moment! No worries! I had this integration in the pipeline since more than a year, so it can wait all...

My position has shifted two days after my initial try on #805. See [this comment](https://github.com/gtk-rs/gtk-rs-core/issues/805#issuecomment-1288079608). Sorry if that lead to confusions, I made it clear in the initial comment now....

@bilelmoussaoui: indeed that would be useful. Something like [`Option::take_if`](https://doc.rust-lang.org/std/option/enum.Option.html#method.take_if) in reverse? I can add that too yes.

Noteworthy annoyance with these changes is that we need to `use glib::prelude::*;` (or `gst::prelude::*;`) in some places were it wasn't before.

> I propose renaming property_if_any() to property_if_not_empty() to clarify its purpose and to be more similar to the common is_empty() collection method Makes sense. > I would name it property_if_some...

Just wanted to note that this seems related: https://github.com/pdeljanov/Symphonia/pull/109

> The signature is probably an obstacle for new users, as is the requirement to do something special for the NONE case. That's true, but with Rust expressive type system,...

I gave this some more thoughts and made some changes to my experiment. This is also inspired by @sdroege's [introduction of `default()` for `Pipeline` & `Bin`](https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/1136/diffs) as well as a...

@GuillaumeGomez did you reply to the initial comment or to the refined: https://github.com/gtk-rs/gtk-rs-core/issues/805#issuecomment-1288079608 @slomo I'll try to take a look in the coming days. As I said in the comment...