David Feltell

Results 142 comments of David Feltell

Consider return types as well as arguments. For example, in `resolve` if the manager doesn't call a callback, what gets returned? A (vector of) `nullptr` `TraitsDataPtr`(s)... not sure that's a...

I think this issue needs some more thought, and probably breaking changes to the API. The current API for a `ManagerImplementationFactoryInterface` has no concept of plugin search paths. They are...

For posterity: branch on my fork attempting to modify env var in-process: https://github.com/feltech/OpenAssetIO/tree/prototype/1033-pluginPathInConfigFile

For reference, [`ctypes` solution](https://discuss.python.org/t/method-to-refresh-os-environ/54774/6) ``` >>> getenv = ctypes.CDLL(None).getenv >>> getenv.restype = ctypes.c_char_p >>> os.putenv('SPAM', 'EGGS') >>> 'SPAM' in os.environ False >>> getenv(b'SPAM') b'EGGS' ```

I've moved this issue out of the iteration and cleared the points estimate. We'll revisit this further down the line.

This came out of an ASWF Slack conversation that highlighted the deficiency in our docs.

> I am interested in tackling this one! Great! Where do you think such a doc should live? On the one hand, a markdown doc linked in the README would...

Updated description to reflect the fact https://github.com/OpenAssetIO/OpenAssetIO/issues/1340 broke editable installs (and it wasn't worth fixing given the lack of usefulness). Kept this issue around since it's a nice-to-have. But at...

> I noticed whitespace inconsistencies throughout. I like the way you think! Personally, I'd love to be militant about consistency. But realistically, we have to draw the line somewhere, for...

> OK. And — if I read the docs correctly — the whitespace changes can go in this PR, but each in their own commit? Yeah separate commits would be...