Kyle Gerard Felker
Kyle Gerard Felker
Thanks for finding this! I would like to make sure that there isn't a more elegant solution that can avoid all the code duplication. Can you post the full Valgrind...
Thinking about this a bit more... The original `TaskList` and `TimeIntegratorTaskList` class and inheritance design pre-dates me; maybe @tomidakn remembers the details of the original choices. The use of `static_cast`...
retest this please
@yanfeij is there a plan to open a branch at least with this fix?
yes that'd be great!
``` Your Athena++ distribution has now been configured with the following options: Problem generator: jgg Coordinate system: cartesian Equation of state: isothermal Riemann solver: hlld Magnetic fields: ON Number of...
if I recall correctly, the code already has something like `3f` in it? If the mesh is nonuniform and/or curvilinear, we use Mignone (2014) which clips smooth extrema? https://github.com/PrincetonUniversity/athena/blob/e39297859810e5e95b45b59e9004bdf8b8c5a5a3/src/reconstruct/ppm_simple.cpp#L171-L174 how...
@tomidakn can you check that my latest suggestion is what is intendend? I had to remind myself of the counter-intuitivie operator precedence rules in C re: bitwise operators and arithmetic...
don't worry, I have scolded the AI