trlib icon indicating copy to clipboard operation
trlib copied to clipboard

patches from SciPy

Open lucascolley opened this issue 9 months ago • 5 comments

Hi @felixlen, would you be interested in taking on patches from SciPy, such that we could have a more sane vendoring situation, where there is just one copy of the code to be maintained rather than two?

I think it would be great, so that any fixes you make here will propagate to SciPy users, and any SciPy contributors sending fixes will be redirected here.

Cross-reference https://github.com/scipy/scipy/issues/21232

I list here potentially substantive changes:

  • https://github.com/scipy/scipy/commit/b7580c33eb5d6d527112abf280dd288e53742215
  • https://github.com/scipy/scipy/commit/5caefe5083d327a274b2eb40b8ea468a474ff1d4
  • https://github.com/scipy/scipy/commit/5b3b71d8005cb57d15d6b21fced961b88b98e280#diff-cb62f28bff34f02041849c25e5df23241f3b234c960fab678cd5188de219f19b
  • https://github.com/scipy/scipy/commit/2d6be1c71322c33a7151f1620d633711715b6a7b#diff-cb62f28bff34f02041849c25e5df23241f3b234c960fab678cd5188de219f19b
  • https://github.com/scipy/scipy/commit/2f4bd4234370adcd7085bcc145f9c302f231408f#diff-cb62f28bff34f02041849c25e5df23241f3b234c960fab678cd5188de219f19b
  • https://github.com/scipy/scipy/commit/0f6d90f1566950e200a2917ba4fa4aad5ca42684#diff-3779d1837786e19b784eb875d2b2a5d71dd92a2f04ebb24243c988aea773feb9
  • https://github.com/scipy/scipy/commit/751ecb6cb5e7947b9bd51e5e9fdd200c09ba8a2a
  • https://github.com/scipy/scipy/commit/b8d6a0a0d6a275555a58136b0bc35c0b6c872aa9
  • https://github.com/scipy/scipy/commit/6e4fbf9b2cb725a501ad10a2ab6eaa4d5c2747cd#diff-cb62f28bff34f02041849c25e5df23241f3b234c960fab678cd5188de219f19b

And assorted formatting/typo changes:

  • https://github.com/scipy/scipy/commit/9d0f6c3a84f31fe4f3552185db70b5c4a3e89d48#diff-4cff528f49b05555d28744b0f6964808723283f90e127b2572f01b3f693e1b6d
  • https://github.com/scipy/scipy/commit/6fb46e0362764a6a0f39c47992897e7291009313#diff-dccb6378eccd8f5c0050595b71857e45aef9a2114f28ccf591bc335ca4f11dab
  • https://github.com/scipy/scipy/commit/9e5975f3a10b238f1e8815a7cb693c954d5f8f6b#diff-252650bc16fea2404c2f7e06f6cd57e9503a1bffc9d692d96efc70d53bd836de

lucascolley avatar May 04 '25 12:05 lucascolley

Hi @lucascolley, thanks for bringing this up. In general I am interested in keeping in sync. Currently I have no time to look at these suggestions, but the situation will be better in August and then will have the capacity to see what can be included. Does this work for you?

felixlen avatar May 21 '25 21:05 felixlen

thanks @felixlen, yes, that sounds great!

lucascolley avatar May 21 '25 21:05 lucascolley

the situation will be better in August and then will have the capacity to see what can be included.

Hey @felixlen ! It looks like August has been and gone... but maybe you still have some capacity to take a look at this?

lucascolley avatar Sep 06 '25 13:09 lucascolley

Thanks for the reminder. Sorry, the situation has changed on my side. Short-term I will not be able to spent time on this, but I would still be interested in including the patches mid-term. Is there a timeline from your side that should be followed?

felixlen avatar Sep 15 '25 11:09 felixlen

Thanks for the reminder. Sorry, the situation has changed on my side. Short-term I will not be able to spent time on this, but I would still be interested in including the patches mid-term. Is there a timeline from your side that should be followed?

No particular timeline, I will be busy with university for the following year but I should have time to help answer questions whenever you get time to look into this!

lucascolley avatar Sep 15 '25 11:09 lucascolley