Felix Fontein
Felix Fontein
@agabidullin63 can you remove the `unittest.main()`? I think then the PR is fine.
I think this looks good. Do you plan to rename your account more times, or are you planning to stick to the current name (at least for some time)? :)
@a-gabidullin thanks a lot for your contribution! @russoz thanks for reviewing!
> My guess is that the previous (co)authors of the redfish_utils.py misunderstood this text and thought that the etag should have been _supplied_ in `If-Match` header in the module: But...
I hope you'll get a reply. Maybe also the module maintainers, @panyy3 @renxulei, might be able to find out more.
@GuillaumeDorschner what about: > If `id` is required for creation, the code should also enforce this. Would you mind adding a check to it in the creation code-path?
I was not talking about the `required` attribute. I was talking about the field being required when something is actually created, i.e. in this code-path: https://github.com/ansible-collections/community.general/blob/a5d65bde53f8a43f861e65f657d5dfcfc3d20454/plugins/modules/keycloak_realm.py#L1089-L1104 If the documentation change...
@GuillaumeDorschner don't mark it as required. Add a check in the code that makes sure `id` is specified if the realm needs to be created.
No, in that case the ID would also be required when updating, not only when actually creating. Whether something is created is only known in the code after checking whether...
> The cause of the badNonce error is that LetsEncrypt runs a large number of servers to deal with the load. If we request an nonce from a server, then...