Felix Fontein

Results 1983 comments of Felix Fontein

The import API supports a `platform` query parameter since 1.48: https://docs.docker.com/reference/api/engine/version/v1.48/#tag/Image/operation/ImageLoad The export API does not seem to support that, at least not in the API documentation: https://docs.docker.com/reference/api/engine/version/v1.48/#tag/Image/operation/ImageGetAll Some more...

> If its OK to proceed I'd be happy to contribute. That's fine from my side - but be warned that idempotency for `docker_image_load` will be non-trivial. For export it...

If nobody objects I'll merge this tomorrow.

@Lithimlin thanks for your contribution! @russoz thanks for reviewing!

CC @froebela @sam-lunt @hobnob11 you did fixes to this modules in the past, maybe you could take a look at this one.

> nd "no" for ansible, as I mentioned in my second comment, we can't rewrite history, if there are already systems using old format and ansible controls them, then it...

As you have noticed we will not merge your current version. If you insist on getting this merged as-is (without addressing the issues that were pointed out), this won't get...

I guess something like `module.run_command_environ_update = dict(LANG='C', LC_ALL='C', LC_MESSAGES='C', LC_CTYPE='C')` (or using the `environ_update` parameter of `module.run_command()` with a similar dict) would help here.

Another enhancement: adding the right `backport-X.Y` labels to the PR. Right now someone has to do this manually.