Don't suggest private methods

[gnoe]

To avoid errors on Travis with line ending.

This branch has the same fix for showing private and protected methods and properties out of the context.

Fixes #469

[felixfbecker]

Could you add a test for this?

[gnoe]

Yes, I can. Should I add it to tests\Server\TextDocument\CompletionTest.php? I tested this launching the php-intellisense extension pointing to my local copy of the language server. I will write the test.

Travis keeps failing because of the line ending.

[felixfbecker]

What editor are you using? You should configure it to trim trailing whitespace (or delete it manually)

[gnoe]

I use VS Code and Netbeans, I configured VS Code. Thanks! Next commit with the test should be fixed

[codecov[bot]]

Codecov Report

Merging #682 into master will increase coverage by 0.2%. The diff coverage is 93.33%.

@@             Coverage Diff             @@
##             master     #682     +/-   ##
===========================================
+ Coverage     82.17%   82.38%   +0.2%     
- Complexity      935      944      +9     
===========================================
  Files            44       44             
  Lines          2154     2168     +14     
===========================================
+ Hits           1770     1786     +16     
+ Misses          384      382      -2

Impacted Files	Coverage Δ	Complexity Δ
src/CompletionProvider.php	94.32% <100%> (+0.07%)	113 <0> (+1)	:arrow_up:
src/Definition.php	95.65% <90.9%> (-4.35%)	14 <8> (+8)
src/DefinitionResolver.php	87.8% <0%> (+0.34%)	332% <0%> (ø)	:arrow_down:
src/Index/Index.php	78.22% <0%> (+0.8%)	54% <0%> (ø)	:arrow_down:

[felixfbecker]

Would you mind fixing merge conflicts?

[gnoe]

I did merge the branch already, sorry, I have to get used to the code. I removed the part of the static checking. I would like to test it better.

[codecov-io]

Codecov Report

Merging #682 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #682   +/-   ##
=========================================
  Coverage     82.38%   82.38%           
  Complexity      944      944           
=========================================
  Files            44       44           
  Lines          2168     2168           
=========================================
  Hits           1786     1786           
  Misses          382      382