php-language-server icon indicating copy to clipboard operation
php-language-server copied to clipboard

Go to Definition in PHPDoc comments

Open felixfbecker opened this issue 8 years ago • 8 comments

From @razvanphp on November 4, 2016 18:54

Not sure how I can explain better, but this would be very useful, especially for private variables in classes.

Thank you for this great extension, makes VSCode perfect!

Copied from original issue: felixfbecker/vscode-php-intellisense#28

felixfbecker avatar Nov 04 '16 19:11 felixfbecker

I would love to support this, but I don't get any location info from phpDocumentor for the tags.

felixfbecker avatar Nov 04 '16 19:11 felixfbecker

From @razvanphp on November 4, 2016 19:3

Maybe you can open a feature request issue there?

felixfbecker avatar Nov 04 '16 19:11 felixfbecker

https://github.com/phpDocumentor/ReflectionDocBlock/issues/87

felixfbecker avatar Nov 04 '16 19:11 felixfbecker

PHP support for https://github.com/joelday/vscode-docthis has been a pretty big request. I'm working on switching to a multiple language architecture, but I want to make sure that I'm going in the right direction or if I should do this at all. I sent @mousetraps a quick e-mail about this, too.

This is also pretty sensitive given the runtime implications of PHPDoc comments, which is going to require very careful testing and CI on my part. Any thoughts?

joelday avatar Mar 02 '17 17:03 joelday

@joelday I think this functionality can be provided much easier in the language server. But automatic documentation !== go to definition in docblocks.

felixfbecker avatar Mar 02 '17 17:03 felixfbecker

@felixfbecker

But automatic documentation !== go to definition in docblocks.

Totally. :)

joelday avatar Mar 02 '17 17:03 joelday

is this now possible due to adoption of Microsoft/tolerant-php-parser?

razvanphp avatar Aug 09 '18 19:08 razvanphp

@felixfbecker is PHPDoc implemented? -- edit -- I mean autocomplete based on PHPDoc (@method, @see, @var) and corresponding code navigation.

vbabak avatar Dec 04 '19 09:12 vbabak