node-sql-template-strings icon indicating copy to clipboard operation
node-sql-template-strings copied to clipboard

Sql statement parameter

Open Toumetis opened this issue 7 years ago β€’ 6 comments

Fixes #30 and adds the ability to perform raw substitutions in the SQL call (c.f. calling append(string))

Toumetis avatar Jul 11 '17 17:07 Toumetis

Codecov Report

Merging #45 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #45   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          28     45   +17     
=====================================
+ Hits           28     45   +17
Impacted Files Coverage Ξ”
index.js 100% <100%> (ΓΈ) :arrow_up:

codecov[bot] avatar Jul 11 '17 18:07 codecov[bot]

Please grab some tests from #31 to ensure that all cases are covered. For example, I don't see test for edge case:

SQL`${SQL`SELECT`} * FROM table`

Strate avatar Nov 13 '17 19:11 Strate

Development here looks halted? I haven't noticed this and did my own implementation and opened another PR. I think I got few edge cases covered where this PR will break. https://github.com/felixfbecker/node-sql-template-strings/pull/79

I appreciate work done here regarding RAW, but I think this ideally should be a separate PR.

skyjur avatar Apr 29 '18 18:04 skyjur

Are there any status updates on this?

klandell avatar Aug 29 '18 20:08 klandell

@klandell there is already prepared #31, but abandoned by @felixfbecker as "too complex"

Strate avatar Aug 30 '18 12:08 Strate

@Strate I understand your frustration but please understand my desire as a maintainer to keep code understandable. I didn't close your PR, I said that my gut feeling was that there must be a way to simplify. If there is none, I would be fine with merging it if the code gets some inline comments, especially the parts I pointed out as hard to understand.

felixfbecker avatar Aug 30 '18 15:08 felixfbecker