Felix Bünemann

Wouldn't this be much more efficient using a path based tree that stores the components of the path as a string or array in the database (like the [ancestry gem](https://github.com/stefankroes/ancestry))?

Maybe it makes sense to implement a generic abort mechanism into both `walk_tree_bfs` and `walk_tree_dfs`, so it's easier to build more complex behavior on top of it.

I'd be open to a PR that adds an :abort or :stop signal to the bfs/dfs methods. I think the walk_tree_to_children itself is a bit use case specific, because there...

I'd be weird to have the feature only work for DFS, don't you think that would be confusing for the users?

I don't understand the comment. If the column(method `#level` already exists you can use `#tree_level`.

Yes, this should be mentioned. I think you can omit the `window.` at the front.

There are several issues here: - Use `@countries.includes(:states)` to avoid n+1 queries on states - Drop the `has_one :country` on the `StateSerializer` and replace with `attribute :country_id` to avoid n+1...

Btw. pulling all countries and states amounts to roughly 10 MBytes of JSON uncompressed.

Done, see PR #29.

Shouldn't `TLSEnable yes` be `TLSEnable no` when using `ldaps://` protocol? LDAPS uses plain SSL on port 636, while StartTLS ist used with `ldap://` protocol on port 389, where the connection...