Felix Hildén

Results 253 comments of Felix Hildén

Thanks! I think this issue still needs some discussion, but there's been related work on blank lines recently in #3035 and #2996. Personally, I'd like to see them removed. And...

Stable is looming closer than ever, so should we use it as an opportunity to finally define this public API?

#1544 suggested having a dedicated function for checking a code sample for modifications. Could be nice.

We could try to take this forward. Perhaps we can first commit to the simplest API and then expand as needed. So, we could only expose a function for formatting...

Appreciated, but could you elaborate on `[tuple(call) ...`'s position changing in the second example to be in the `dict` and the last to be outside the list? I guess this...

Thanks for submitting! This sounds pretty good to me.

FWIW, we do require the comments to be in the same block, although [the documentation](https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html?highlight=fmt%3A%20off#code-style) could be clearer about it. As to your other concern, I managed to simplify a...

Definitely related, but I propose we edit this issue to be about the misspell bug and open a new design issue for letting (or deciding against) `# fmt: off/on` spanning...

In the meantime, it appears to happen even if the second comment is missing: [playground](https://black.vercel.app/?version=main&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4ACkAFtdAD2IimZxl1N_WlXnON2nzNX9HFvHx6cBGYYzxnKDXUC9bWnmZzMczz8-5oZsWrpdgU6quHPZdEvQmAg39fC5tScCiaDH3kbKBHJ-quOfPTSCcODcQLbiErAffiAAAJEww3dpp7KJAAF3pQEAAAAnngnVscRn-wIAAAAABFla) ```python class Foo: # fmt: off 1 class Bar: # fmt: off 1 # fmt:...

I updated docs in the PR linked above. So some thoughts about this issue: I think in this situation, assuming we won't change `# fmt: off/on` to allow arbitrary placement,...