react-native-animated-dots-carousel icon indicating copy to clipboard operation
react-native-animated-dots-carousel copied to clipboard

verticalOrientation not working

Open nazacity opened this issue 1 year ago • 3 comments

react native 0.76.2 react-native-gesture-handle 2.21.0 react-native-animated-dots-carousel 2.0.0

<AnimatedDotsCarousel
    length={2}
    currentIndex={index}
    maxIndicators={1}
    activeIndicatorConfig={styles.activeIndicator}
    inactiveIndicatorConfig={styles.inactiveIndicator}
    verticalOrientation
    decreasingDots={[
                            {
                                config: { color: COLORS.gray[1], margin: 3, opacity: 0.6, size: 8 },
                                quantity: 1
                            }
    ]}
 />

nazacity avatar Nov 19 '24 11:11 nazacity

@nazacity Hey! Could you show what issue are you having? Could you add a picture?

frodriguez-hu avatar Nov 27 '24 17:11 frodriguez-hu

Screenshot 2567-12-23 at 14 01 13

I worked around by add

diff --git a/node_modules/react-native-animated-dots-carousel/lib/commonjs/CarouselDots/index.js b/node_modules/react-native-animated-dots-carousel/lib/commonjs/CarouselDots/index.js
index b3aa393..857f758 100644
--- a/node_modules/react-native-animated-dots-carousel/lib/commonjs/CarouselDots/index.js
+++ b/node_modules/react-native-animated-dots-carousel/lib/commonjs/CarouselDots/index.js
@@ -129,7 +129,7 @@ const CarouselDots = ({
     children: /*#__PURE__*/(0, _jsxRuntime.jsxs)(_reactNative.ScrollView, {
       ref: refScrollView,
       contentContainerStyle: [_styles.default.scrollContainer, {
-        flexDirection: _reactNative.I18nManager.isRTL ? 'row-reverse' : 'row'
+        flexDirection:verticalOrientation ?'column': _reactNative.I18nManager.isRTL ? 'row-reverse' : 'row'
       }],
       bounces: false,
       horizontal: !verticalOrientation,

look like flexDirection is not passed to its children any more

nazacity avatar Dec 23 '24 19:12 nazacity

@nazacity Would you mind creating a pr and uploading evidence?

frodriguez-hu avatar Dec 23 '24 20:12 frodriguez-hu