node-semver-rs icon indicating copy to clipboard operation
node-semver-rs copied to clipboard

`MAX_SAFE_INTEGER` has the wrong value.

Open coffinsfcompute opened this issue 1 year ago • 1 comments

MAX_SAFE_INTEGER has the wrong value. It is:

pub const MAX_SAFE_INTEGER: u64 = 900_719_925_474_099;

it should be

pub const MAX_SAFE_INTEGER: u64 = 9_007_199_254_740_991;

coffinsfcompute avatar Oct 28 '24 22:10 coffinsfcompute

huh.

....I guess whoever copy-pasted that number failed to copy paste the final 1 (probably me)? Sorry about that. Would you like to PR this change?

zkat avatar Oct 29 '24 16:10 zkat