iskra-webkit-greeter icon indicating copy to clipboard operation
iskra-webkit-greeter copied to clipboard

Feature/pkgbuild

Open coquizen opened this issue 4 years ago • 6 comments

In order to maintain directory-name consistency with /usr/share/lightdm-webkit/themes, I changed the install directory to /usr/share/lightdm-webkit/themes/iskra instead of /usr/share/lightdm-webkit/themes/iskra-webkit-greeter. This necessitated path changes at points in various other files. Furthermore, I amended a typo in the .gitignore, amended engine=lightdm-webkit-greeter to the more appropriate engine=lightdm-webkit2-greeter. I have also drafted a PKGBUILD file for AUR packaging.

May I suggest changing the name of the git repository to lightdm-webkit2-theme-iskra to maintain naming consistency with other lightdm-webkit2 themes? If you choose to do so, the PKGBUILD needs to be updated accordingly.

coquizen avatar Aug 01 '19 15:08 coquizen

Thank you for the contribution @CaninoDev ! The PKGBUILD addition is super useful!

But, why did you rename session=gnome to session=xfce4?

felipemarinho97 avatar Aug 07 '19 14:08 felipemarinho97

Oh whoops.. That is an oversight on my part (I only have XFCE4 installed and specified XFCE as the default session.

coquizen avatar Aug 07 '19 14:08 coquizen

Okay, in fact, gnome also is not my default session, but it is like this in the file because it's probably the most used.. Also, did you intend to be the maintainer of this PKGBUILD on AUR? the available release is very old and maybe I'll make another release with the most latest changes

felipemarinho97 avatar Aug 07 '19 14:08 felipemarinho97

I can volunteer to be the maintainer of the AUR package. When do you think we can expect the new release?

coquizen avatar Aug 07 '19 18:08 coquizen

Also how would you like to license git? GPL? MIT?

coquizen avatar Aug 07 '19 18:08 coquizen

@CaninoDev Nice! =D I will release in less than 1 week, probably this weekend.. you can license it on GPL

felipemarinho97 avatar Aug 08 '19 12:08 felipemarinho97