feldera icon indicating copy to clipboard operation
feldera copied to clipboard

Fix StreamingTests Assertion for Storage

Open gz opened this issue 2 years ago • 2 comments

https://github.com/feldera/feldera/blob/f69c5bcd50b97065dd50d8f5f5b1fad18bd5ad65/sql-to-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/streaming/StreamingTests.java#L382

gz avatar Feb 20 '24 22:02 gz

This will need help from the profiling infrastructure to collect data for storage too. The right way to disable the test is to use @Ignore. But this will work too for now.

mihaibudiu avatar Feb 20 '24 22:02 mihaibudiu

This will need help from the profiling infrastructure to collect data for storage too. The right way to disable the test is to use @Ignore. But this will work too for now.

I prefer commenting out the assertion because the part that comes before it triggered a bug in the storage implementation that wasn't triggered by other tests.

blp avatar Feb 20 '24 22:02 blp