foundryvtt-docker icon indicating copy to clipboard operation
foundryvtt-docker copied to clipboard

Container Patch Scripts for Prebuilt Images

Open OrangeDrangon opened this issue 4 years ago • 1 comments

🚀 Feature Proposal

Enable some method of running container patch scripts for containers built with credentials.

Motivation

I prefer to build the containers with foundry installed using my credentials but also enjoy the convenience of the patch scripts. I personally patched entrypoint.sh to run the patch scripts every launch not just when foundry is being installed but figured there might be a better mechanism for this. Potentially running them during container build. Figured I would propose the option.

Example

The best implementation of this I see is adding patch scripts as a build ARG just like the credentials are. This would enable the scripts to be run just once while also providing nearly the same experience as passing the urls as environment variables.

Pitch

It is a simple extension of a preexisting feature. Should add little to no maintenance cost on the project. I would be willing to give it a go for my own personal usage if anyone is interested here.

OrangeDrangon avatar Jun 22 '21 22:06 OrangeDrangon

Opened a pull request draft that begins to address this.

OrangeDrangon avatar Jul 04 '21 23:07 OrangeDrangon