mason icon indicating copy to clipboard operation
mason copied to clipboard

fix: `mason update` doesn't work

Open SAGARSURI opened this issue 2 years ago • 4 comments

Description

When I run the command mason update. It's not updating mason to the latest version. I am on macOS Ventura 13.2.

Steps To Reproduce

  • Check the installed version of the mason.
  • Run mason update
  • Run mason --version
  • mason is not updated

Expected Behavior

mason should be updated to the latest version

Screenshots

Screenshot 2023-02-02 at 11 40 50

Additional Context

Add any other context about the problem here.

SAGARSURI avatar Feb 02 '23 10:02 SAGARSURI

So the issue with mason update is, it doesn't work if a user has installed mason using brew. I am planning to create a package(brew_updater) similar to pub_updater but that will use brew to update an existing dependency. What do you think?

SAGARSURI avatar Feb 02 '23 13:02 SAGARSURI

So the issue with mason update is, it doesn't work if a user has installed mason using brew. I am planning to create a package(brew_updater) similar to pub_updater but that will use brew to update an existing dependency. What do you think?

Good catch! Yeah that seems reasonable. We’ll also need to have logic to determine whether the mason installation was done through pub or brew in order to determine which mechanism to use for update checks.

felangel avatar Feb 03 '23 02:02 felangel

Perfect! I will create a PR soon 😃 . Thanks for your input.

SAGARSURI avatar Feb 03 '23 11:02 SAGARSURI

+1 does not work for me

luongvo avatar Apr 21 '23 07:04 luongvo