fresh icon indicating copy to clipboard operation
fresh copied to clipboard

Replace graphql dependency with gql_link

Open ninogjoni opened this issue 3 years ago • 3 comments

It is just an idea, but can the dependency be changed from graphql to gql_link? Is it even possible? The maintainer of ferry mentioned it in a comment: https://github.com/gql-dart/ferry/issues/296

Any thoughts about the comment?

ninogjoni avatar Feb 10 '22 17:02 ninogjoni

Hi!

Maintainer of ferry and gql-dart here.

What @ngjoni is asking here is just to swap out the dependency from graphql to gql_link. (https://pub.dev/packages/gql_link ) If you follow the import, you can see that the Link class exported from package graphql is from gql_link, so you are using gql_link anyway.

All graphql clients in Dart that I know of (graphql, ferry, and artemis) use some base packages from the gql-dart ecosystem. So if you just depended on gql_link instead of grapqhl, all graphql clients could use this package without pulling in a whole other graphql client as a dependency.

knaeckeKami avatar Aug 16 '22 23:08 knaeckeKami

Hi!

Maintainer of ferry and gql-dart here.

What @ngjoni is asking here is just to swap out the dependency from graphql to gql_link. (https://pub.dev/packages/gql_link ) If you follow the import, you can see that the Link class exported from package graphql is from gql_link, so you are using gql_link anyway.

All graphql clients in Dart that I know of (graphql, ferry, and artemis) use some base packages from the gql-dart ecosystem. So if you just depended on gql_link instead of grapqhl, all graphql clients could use this package without pulling in a whole other graphql client as a dependency.

Hi @felangel , thanks for your great work on this library! Just wonder would that be possible as it seems there are some conflicts on resolving with latest ferry and latest graphql_flutter package together... 🧐

Thanks!

chungonion avatar Oct 07 '22 03:10 chungonion

This can be closed: https://github.com/felangel/fresh/pull/77

ebsangam avatar Apr 07 '23 08:04 ebsangam