Felix Angelov comments

Results 772 comments of


                                            Felix Angelov

fix: avoid_public_bloc_methods for getters

Hi @aggeloskoutanis 👋 Thanks for opening an issue! Can you please provide a bit more context regarding what the specific getter is used for in your case? This is currently...

fix: HydratedMixin causes BlocBase to emit the same state

For context, the reason for this behavior was to explicitly support notifying listeners which would otherwise potentially never be notified. This change in behavior would be a breaking change and...

Add Intentions for cubits

Thanks for the PR! I'll take a closer look shortly. I want to see if there is a better way to address the problem you're facing without duplicating all the...

fix(bloc_test)!: forward _TestBlocObserver events to localObserver

@alestiago thanks for the PR and sorry for the delay! I took a look and I'm just wondering if you can provide some context for why this change is necessary....

fix(bloc_test)!: forward _TestBlocObserver events to localObserver

Thanks for the context! Regarding testing internal events, I would focus on testing the output of those events rather than trying to verify that the internal event was added. In...

feat(bloc_lint): add `avoid_bloc_to_bloc_members`

Thanks I'll take a closer look shortly!

fix(hydrated_bloc): prevent duplicate emissions after hydration

Thanks for the PR! I need to think about this a bit more carefully because this will potentially break any apps which depend on `BlocListeners` being triggered by state hydration.

feat(bloc_lint): avoid_async_emit

I'd recommend using https://dart.dev/tools/linter-rules/use_build_context_synchronously for inspiration. It should be very similar in terms of requirements/implementation.

ci: use local `bloc_tools` in `flutter_package` workflow

This is blocked on Flutter supporting the latest version of the analyzer frontend.

shouldApplyToken: Add ability to skip adding authentication header

Hi @passsy 👋 Thanks for filing the issue! Thoughts on the following API: ```dart Fresh.oAuth2( tokenHeader: (token) { return {'Authorization': 'Bearer ${token.accessToken}'}; }, // Optional (returns true by default for...