URLColors icon indicating copy to clipboard operation
URLColors copied to clipboard

Published 20 hours ago • verified publisher icon fej-snikduj

Update background.js

Open cesarmtnez opened this issue 4 years ago • 8 comments

Apply styles to all tab frames

cesarmtnez avatar Jun 22 '20 13:06 cesarmtnez

Apply styles to all tab frames

Hi @cesarmtnez - can you give me an example to test this out on? I'm not entirely sure how to reproduce - is this referring to iframes?

fej-snikduj avatar Jun 24 '20 17:06 fej-snikduj

Hello @fej-snikduj.

I usually have to use a internal page with the old tag <frameset>. Let me show you an example without content:

<html xmlns="http://www.w3.org/1999/xhtml" style="cursor: inherit;">
<head>
    <title>Foo</title>
    <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<frameset rows="63,*" frameborder="NO" border="0" framespacing="0" style="opacity: 1; pointer-events: inherit;">
    <frame src="notFound.html" name="topFrame">
    <frame src="notFound.html" name="mainFrame">
</frameset>
<noframes>
    <body>
    Unsuported frames
    </body>
</noframes>
</html>

In those kind of pages the extension does not show any style. With the param allFrames:true (PR) the extension prints the style for each frame.

cesarmtnez avatar Jun 25 '20 06:06 cesarmtnez

Hello @fej-snikduj

Have you been able to test my example?

Regards.

cesarmtnez avatar Jul 13 '20 08:07 cesarmtnez

Hi, so sorry for being so slow. I’m on vacation right now but finishing up

  • will try and test before Monday

On Mon, Jul 13, 2020 at 1:22 AM cesarmtnez [email protected] wrote:

Hello @fej-snikduj https://github.com/fej-snikduj

Have you been able to test my example?

Regards.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/fej-snikduj/URLColors/pull/5#issuecomment-657402533, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2MY7INRQTYBR4Q4E5MQG3R3K737ANCNFSM4OESWDVQ .

fej-snikduj avatar Jul 16 '20 13:07 fej-snikduj

@cesarmtnez - I tested this out. It works as expected - though I'm concerned it my not be the expected behavior for all the users out there - some users may be surprised that their frames are now displaying a border. I think we should make this an option that is defaulted false so all current behavior remains the same for current users - what are your thoughts?

fej-snikduj avatar Jul 20 '20 02:07 fej-snikduj

Sorry @fej-snikduj , but I was on vacation. Yes, you are right and I think your proposed solution is a good idea. I have implemented it and you can see it in this current pull request.

cesarmtnez avatar Aug 11 '20 08:08 cesarmtnez

Hi @fej-snikduj , have you been able to review the pull request?

Greetings

cesarmtnez avatar Oct 30 '20 16:10 cesarmtnez

Hi, any news about this PR approval? It would be useful for some users, for me included

Regards

bender270 avatar Jun 23 '23 09:06 bender270