webextension_local_filesystem_links icon indicating copy to clipboard operation
webextension_local_filesystem_links copied to clipboard

Only folder links and, strangely, python links are working

Open tsbertalan opened this issue 2 years ago • 1 comments

Here's a test page:

<!DOCTYPE html>
<html>

        <ul>
        <li>
        Doesn't work: <a href="file:///home/tsbertalan/Dropbox/Projects/Journal/2022-04-15.md">md</a>
        <li>
        Bizzarely, does work, but only with the link text, not the added icon: <a href="file:///home/tsbertalan/Dropbox/Projects/Journal/clear_undone_template.py">py</a>
        <li>
        Doesn't work: <a href="file:///home/tsbertalan/Dropbox/Projects/Journal/2022-04-12.assets/Screenshot from 2022-04-12 13-50-23.png">Screenshot from 2022-04-12 13-50-23.png</a>

        <li>
        Doesn't work: <a href="file:///home/tsbertalan/Dropbox/Projects/Journal/gearboxadded.png">gearboxadded.png</a>
        <li>
        Doesn't work: <a href="file:///home/tsbertalan/Dropbox/Projects/Journal/2021-11-06 14.37.34 food receipt.pdf">2021-11-06 14.37.34 food receipt.pdf</a>
        <li>Doesn't work:         <a href="file:///home/tsbertalan/Dropbox/Projects/Journal/talked with Erez 20211111.docx">talked with Erez 20211111.docx</a>
        <li>Does work (and <i>/home/tsbertalan/Desktop</i> is a symlink to <i>/home/tsbertalan/Dropbox/Desktop</i>):        <a href="file:///home/tsbertalan/Desktop/">Desktop</a>
        <li>Does work:                <a href="file:///home/tsbertalan/Dropbox/Projects/Journal/">Journal</a>
</ul>

    </body>
</html>

This is with

Is this really the right Linux local helper binary package to be installing??

tsbertalan avatar May 04 '22 19:05 tsbertalan

Also, FWIW, I tried to compile myself with something like

python3 -m venv ~/.virtualenvs/localfilesystemlinks
source ~/.virtualenvs/localfilesystemlinks/bin/activate
sudo apt install python3-gi python3-gi-cairo gir1.2-gtk-3.0
sudo apt-get install gcc libpq-dev -y
sudo apt-get install python-dev  python-pip -y
sudo apt-get install python3-dev python3-pip python3-venv python3-wheel -y
pip3 install wheel
pip install -r src/requirements.txt 
sudo apt install libcups2-dev
pip install -r src/requirements.txt 
bash build/build.sh 

after modifying requirements.txt to

pyparsing==2.2.0
pathlib2==2.3.0
pip-save==0.2.0
packaging==16.8
pygobject
appdirs==1.4.3
six==1.9.0
pycups==1.9.73
pyinstaller

The pyinstaller ran fine and finished quickly, recreating ./bin/ (after I moved it to ./binba/). I then deleted the existing folder and copied bin/linux/local-link-messaging-host into ~/.mozilla/native-messaging-hosts.

However, this "installation" just raised some toast error messages when I restarted Firefox and tried my test links.

I did see after doing this that I probably should have used python2. I can redoing the above with a python2 venv (and probably an unmodified requirements.txt) later, but a better solution would be to link to updated binaries in the post-extension-install page.

tsbertalan avatar May 04 '22 20:05 tsbertalan