webextension_local_filesystem_links icon indicating copy to clipboard operation
webextension_local_filesystem_links copied to clipboard

Extension is causing a flickering of the yellow bar (too long run-time of extension)

Open AWolf81 opened this issue 7 years ago • 0 comments

Today I have detected that there is an issue with script execution during viewing of a pdf in browser. It was a large datasheet with around 500 pages and it occurred during scrolling at my laptop at work.

It briefly flickers the yellow bar on top of the page that's telling that the extension script is running too long.

I've retried it at home and couldn't see that behavior - I have to check this next week.

I've re-produced this behavior affected pages (twitter and https://coolors.co/): coolors.co issue

I have to investigate the code at the mentioned pages. At Coolors it prevents the webpage to load.

Things to check:

  • [x] What happens during loading of the mentioned web app? Check dev console. Not sure why it happens only at some pages.
  • [x] Deactivate the extension if no html page is displayed (e.g. pdfs, xmls, ...) - maybe mime type checking
  • [x] Is there a DOM if a PDF is displayed? In-Browser PDF viewer renders a DOM. Extension should also work with-in PDFs (not tested yet)

Update 11.02.2018: It seems that this is related to jquery-observe and it's not that easy to fix. If I'm disabling the observer the extension runs just some milliseconds. But with the observer it runs > 10 seconds.

Performance info with observer: https://perfht.ml/2nT0gDP

Performance with-out observer: https://perfht.ml/2nRWkmW

For the next version I'll disable dynamic links to avoid the long running script issue. I'll fix this later. It's important to have an updated version because the extension will break some web pages.

AWolf81 avatar Jan 19 '18 16:01 AWolf81